Add malicious sites from polish cert. #2121

utoni · 2023-10-27T13:50:02Z

care about parsing errors for *.list

IvanNardi

While the PR is fine per se (and the error handling is great) I have a "philosophical" doubt:
do we want to start adding lists with ~150K entries to the library?
I know that these lists are somehow optional and any users might skip them...
I had similar doubts with the gambling list, when it increased from the original some K entries to 30k entries...

Just some thoughts... @lucaderi, what do you think?

example/ndpiReader.c

IvanNardi · 2023-10-29T20:05:31Z

While the PR is fine per se (and the error handling is great) I have a "philosophical" doubt: do we want to start adding lists with ~150K entries to the library? I know that these lists are somehow optional and any users might skip them... I had similar doubts with the gambling list, when it increased from the original some K entries to 30k entries...

After some thoughts, I am fine with the list.
I am still not sure about how to handle the performance issue, though

utoni · 2023-10-30T09:28:16Z

A "manual-lists-download" script would solve checking-in large files to git (and reduce init-time if no list was downloaded), but then the user needs to download those and needs to know about such script.

IvanNardi · 2023-10-30T10:28:22Z

Ok, let keep it as you proposed... Could you please change tests/ossfuzz.sh and add a simple trace with a session matching one of these domains, please?