Improved TFTP. Fixes #2075. #2149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utoni
force-pushed
the
improved/tftp-dissect
branch
2 times, most recently
from
4e756a0
to
daed65c
Compare
|
ping @thomasjwinter |
|
One week later... I think we can safely merge that. @utoni, do you agree? Could you rebase, please? |
Signed-off-by: Toni Uhlig <[email protected]>
utoni
force-pushed
the
improved/tftp-dissect
branch
from
daed65c
to
44e824f
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a more structured dissection of zero-terminated strings, TFTP mode as well as TFTP options.
With this PR dissection of OACK packets is possible. See #2075.