Add realtime protocol output to ndpiReader.
#2197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utoni
force-pushed
the
add/output-realtime-protocols
branch
3 times, most recently
from
b51209d
to
6ae320a
Compare
utoni
force-pushed
the
add/output-realtime-protocols
branch
3 times, most recently
from
bcc95cd
to
709e460
Compare
|
The feature is interesting and it might be useful, but I think it should better if it is disabled by default and the user can enable it via a |
utoni
force-pushed
the
add/output-realtime-protocols
branch
from
709e460
to
f894326
Compare
* support for using a new flow callback invoked before the flow memory is free'd * minor fixes Signed-off-by: Toni Uhlig <[email protected]>
utoni
force-pushed
the
add/output-realtime-protocols
branch
from
f894326
to
2e81729
Compare
|
IvanNardi
approved these changes
Jan 4, 2024
|
I'll try to do that in a follow-up. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is basically a copy'n'pasta from #2059 with some small changes.
Not sure if we want to keep the "realtime protocol output" - behavior.
But at least the flow callback might be coming handy in the future.
I've stumbled on that "I wanna output something from the flow struct, but the memory is already free'd" - issue before and this is a nice workaround.