Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebDAV detection support #2224

Merged
merged 7 commits into from
Dec 22, 2023
Merged

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

It's unlikely to find WebDAV over plain HTTP in the wild these days, but I guess it could be useful for enterprise networks where MITM is almost always used. The detection logic is based on HTTP request methods described in RFC4918.

doc/protocols.rst Show resolved Hide resolved
src/lib/ndpi_utils.c Show resolved Hide resolved
src/lib/ndpi_utils.c Show resolved Hide resolved
src/lib/ndpi_utils.c Show resolved Hide resolved
src/lib/ndpi_utils.c Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@0xA50C1A1
Copy link
Contributor Author

Thank you

Thank you for the review as well.

@IvanNardi IvanNardi merged commit 6fc8aa4 into ntop:dev Dec 22, 2023
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the add/webdav-support branch December 22, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants