Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve MySQL detection #2279

Merged
merged 2 commits into from
Jan 25, 2024
Merged

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Slight improvement of MySQL dissector: added MariaDB support and more stringent checks.

Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@0xA50C1A1
Copy link
Contributor Author

@IvanNardi @utoni guys, what do you think about this? I bumped the minimum MySQL version in check from 1 to 4 since there's not many people using these ancient relics.

Well, also authentication plugin support was introduced only in MySQL 4, if memory serves me right.

Copy link
Collaborator

@IvanNardi IvanNardi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@IvanNardi IvanNardi merged commit 9a0affc into ntop:dev Jan 25, 2024
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the improve/mysql-detection branch January 25, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants