Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LoL: Wild Rift detection #2356

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

0xA50C1A1
Copy link
Contributor

Please sign (check) the below before submitting the Pull Request:

Describe changes:

Regarding the detection logic: a UDP session is establishing with the game match start, and the first two packets in this session always have payload lengths of 69 and 359 bytes and contain signatures 0x4000000 (request) and 0x10000000 (response).

@0xA50C1A1
Copy link
Contributor Author

0xA50C1A1 commented Mar 22, 2024

../include/ndpi_typedefs.h:1504:1: error: static assertion failed: "Size of the flow struct increased to more than 1008 bytes, please check if this change is necessary."

@IvanNardi @utoni

Hmmm... Maybe it's somehow possible to add this stuff to the existing Riot Games dissector to avoid creating a new protocol ID.

Btw, here's a pcap sample with the traffic of the entire match if you're interested: lol_wild_rift.zip

@0xA50C1A1 0xA50C1A1 marked this pull request as draft March 22, 2024 14:31
@0xA50C1A1 0xA50C1A1 marked this pull request as ready for review March 22, 2024 16:28
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@IvanNardi
Copy link
Collaborator

../include/ndpi_typedefs.h:1504:1: error: static assertion failed: "Size of the flow struct increased to more than 1008 bytes, please check if this change is necessary."

@IvanNardi @utoni

Hmmm... Maybe it's somehow possible to add this stuff to the existing Riot Games dissector to avoid creating a new protocol ID.

Btw, here's a pcap sample with the traffic of the entire match if you're interested: lol_wild_rift.zip

Sooner or later we need to decide if there is any value in having one protocol id for each games, or if we might switch to something different... (one id for all the games + metadata with specific game indication? one specific id for each "sw house/company"? specific ids only for the most "famous" games?...)

@0xA50C1A1
Copy link
Contributor Author

0xA50C1A1 commented Mar 22, 2024

Sooner or later we need to decide if there is any value in having one protocol id for each games, or if we might switch to something different... (one id for all the games + metadata with specific game indication? one specific id for each "sw house/company"? specific ids only for the most "famous" games?...)

Well, many games use either out-of-the-box stuff like RakNet or Steam Datagram Relay or some generic protocols (NetEase Games, Gaijin Entertainment, Tencent Games) for all games from a publisher/developer, so I don't see a problem with leaving a few IDs for something that stands out.

@IvanNardi IvanNardi merged commit 5b32c98 into ntop:dev Mar 26, 2024
33 checks passed
@0xA50C1A1 0xA50C1A1 deleted the new-app/lol_wild_rift branch March 26, 2024 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants