-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra entropy checks and more precise(?) analysis. #2383
Conversation
908f524
to
3fd0713
Compare
5510db2
to
2eca7c8
Compare
@utoni, do you have a copy of the original paper? |
Unfortunately not. :/ |
2eca7c8
to
7083e0a
Compare
7083e0a
to
374d056
Compare
icmp echo request @IvanNardi :) |
@utoni I am a bit sceptical about this PR. Entropy is a metric to measure chaos, and within specific boundaries you can find many different contents. So ndpi_entropy2str() for instance can IMHO be used as a hint but not for ground truth. So if you position it as hint I am happy, if you want to do more than that I am not convinced it's a good idea |
@lucaderi |
I mean that "Compressed Executable" is not only this, but it's a possibility (or hint if you wish). So a broader set of possibilities (e.g. "Compressed Executable. or something else" or "Compressed Executable ?") can indicate that this is a hint and not a fact true 100%. More or less ad DPI confidence that @IvanNardi introduced in DPi classification some time ago. |
Ok, got it. |
@utoni, are you going to push a new version with updated labels/strings? |
Yea, ASAP :) |
Signed-off-by: Toni Uhlig <[email protected]>
374d056
to
f8f669a
Compare
Quality Gate passedIssues Measures |
done, I've also lowered the risk level from medium to low |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Please sign (check) the below before submitting the Pull Request:
Describe changes:
This is more an idea on how entropy based categorization could give more details about the transmitted data. It's losely based on the Entropy Analysis paper, but needs some verification. Hopefully, someone may find this useful and may help me with it. :)
(not yet done reading the paper)
Also something to consider is if entropy calculation should be done per-packet instead per-flow..