Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Action in ecl/managed_load_balancer/v1/load_balancers/requests #49

Conversation

hico-horiuchi
Copy link
Contributor

@hico-horiuchi hico-horiuchi commented May 10, 2024

Migrate load_balancers.ApplyConfigurations and load_balancers.SystemUpdate to load_balancers.Action .
(to be able to specify both "apply-configurations" and "system-update" in the same API request.)

See also API reference: Action Load Balancer

Test Results

v2

$ cd v2/ecl/managed_load_balancer/v1/
$ go test ./... -count=1
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/certificates	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/certificates/testing	0.254s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/health_monitors	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/health_monitors/testing	0.635s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/listeners	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/listeners/testing	1.170s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/load_balancers	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/load_balancers/testing	1.368s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/operations	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/operations/testing	0.996s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/plans	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/plans/testing	0.443s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/policies	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/policies/testing	0.772s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/routes	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/routes/testing	1.298s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/rules	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/rules/testing	1.238s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/system_updates	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/system_updates/testing	1.227s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/target_groups	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/target_groups/testing	1.054s
?   	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/tls_policies	[no test files]
ok  	github.com/nttcom/eclcloud/v2/ecl/managed_load_balancer/v1/tls_policies/testing	0.901s

v3

$ cd v3/ecl/managed_load_balancer/v1/
$ go test ./... -count=1
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/certificates	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/certificates/testing	0.306s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/health_monitors	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/health_monitors/testing	0.120s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/listeners	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/listeners/testing	0.214s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/load_balancers	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/load_balancers/testing	0.402s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/operations	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/operations/testing	0.533s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/plans	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/plans/testing	0.444s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/policies	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/policies/testing	0.589s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/routes	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/routes/testing	0.601s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/rules	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/rules/testing	0.400s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/system_updates	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/system_updates/testing	0.393s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/target_groups	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/target_groups/testing	0.411s
?   	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/tls_policies	[no test files]
ok  	github.com/nttcom/eclcloud/v3/ecl/managed_load_balancer/v1/tls_policies/testing	0.412s

@hico-horiuchi hico-horiuchi force-pushed the fix_action_in_ecl_managed_load_balancer_v1_requests branch from 4a4af37 to 57f42da Compare May 24, 2024 00:21
@sugimo-s sugimo-s merged commit dab376f into nttcom:master May 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants