adds warning that KNtimeshift is deprecated #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temporary warning to retain compatibility with previous codebases, should remove in future update after users have time to change priors
mcoughlin
requested changes
Sep 8, 2023
tylerbarna
commented
Sep 8, 2023
mcoughlin
merged commit b688b93
into
nuclear-multimessenger-astronomy:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent update breaks compatibility with old prior files due to renaming of KNtimeshift parameter to timeshift, this PR has a few lines of code that restore compatibility but warns users that KNtimeshift will no longer work at some point in the future.