Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set random seed for python/numpy/tf during nn training #236

Merged

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Sep 14, 2023

This PR sets the random seed for python/numpy/tensorflow during NN training. Previously only the numpy random state was set, leading to a variation in training results from run to run.

@mcoughlin
Copy link
Member

@bfhealy Maybe we modify this to default to some value at the command line but still allow us to control it in some way?

@bfhealy
Copy link
Collaborator Author

bfhealy commented Sep 14, 2023

@mcoughlin I agree, the latest commit allows --random-seed to be input to create_svdmodel.

@mcoughlin mcoughlin self-requested a review September 14, 2023 18:50
Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit 6d01895 into nuclear-multimessenger-astronomy:main Sep 14, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants