Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeshift to time values to fix analysis error #281

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add timeshift to time values to fix analysis error #281

merged 1 commit into from
Nov 30, 2023

Conversation

bfhealy
Copy link
Collaborator

@bfhealy bfhealy commented Nov 29, 2023

This PR resolves #280 by adding the timeshift to the t values that are later used for interpolation when plotting analysis results.

mcoughlin
mcoughlin approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcoughlin mcoughlin merged commit 4bfc5ea into nuclear-multimessenger-astronomy:main Nov 30, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcoughlin mcoughlin mcoughlin approved these changes

@tsunhopang tsunhopang Awaiting requested review from tsunhopang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ValueError when plotting analysis results due to timeshift
2 participants
@bfhealy @mcoughlin