Remove LANL2022 model in favor of specific morphologies #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfhealy
merged commit 26000a7
into
nuclear-multimessenger-astronomy:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the model list and documentation to remove LANL2022 in favor of the specific morphologies: LANLTS1, LANLTS2, LANLTP1, and LANLTP2. The original LANL2022 model was trained on all four morphologies and thus produced unphysical results. The trained LANL2022 models have also been removed from gitlab, and the four morphologies have been added.
Note that
LANL2022.priorremains in place, since it can be used in sampling for any of the morphologies.