Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

systematics docs #387

Conversation

sahiljhawar
Copy link
Member

Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent. Perhaps do you want to include an example plot from your paper?

Copy link
Member

@mcoughlin mcoughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also wonder if we should add your citation to the front README for when folks should cite your paper in particular if they turn on systematics.

@sahiljhawar
Copy link
Member Author

@mcoughlin We haven't use any "systematic corner plots" in the paper, instead we always used the systematics to do interpolation for the light curves which I feel is beyond the scope of the documentation (however I can explain it if someone wants to use it in their workflow).

Citation in front README sounds good to me.

@sahiljhawar sahiljhawar merged commit 690ddff into nuclear-multimessenger-astronomy:main Nov 3, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants