Bug Fix - Ember serve fails to incorporate changes outside of includePaths
#49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a regression caused by the 19.1 upgrade.
To Reproduce:
ember serve
Hello/Label.elm
- update text fromSend
toNew Send
Expected
See send button w/ text
New Send
Actual
See send button w/ text
Send
Making any update to
Main/Chat.elm
and saving then results inNew Send
coming through.Solve
It seems using
includePaths
made it so that the build output was considered a result of only the files withinincludePaths
, when the nature of elm compilation means the build output needs to take into account changes to files outside ofincludePaths
.This fix opts instead to use our own
mainDirs
option to whitelist a set of paths for Elm compilation inclusion, so that ember/broccoli still considers all elm files to be incorporated into the output asset.I've tested this out in our larger ember/elm project, and it works well there too.
To get this fix working in your project, make sure you remove
includePaths
from yourember-cli-build.js