Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - Ember serve fails to incorporate changes outside of includePaths #49

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

thematthopkins
Copy link

This addresses a regression caused by the 19.1 upgrade.

To Reproduce:

  1. ember serve
  2. open Hello/Label.elm - update text from Send to New Send
  3. open browser to dummy app

Expected

See send button w/ text New Send

Actual

See send button w/ text Send

Making any update to Main/Chat.elm and saving then results in New Send coming through.

Solve

It seems using includePaths made it so that the build output was considered a result of only the files within includePaths, when the nature of elm compilation means the build output needs to take into account changes to files outside of includePaths.

This fix opts instead to use our own mainDirs option to whitelist a set of paths for Elm compilation inclusion, so that ember/broccoli still considers all elm files to be incorporated into the output asset.

I've tested this out in our larger ember/elm project, and it works well there too.

To get this fix working in your project, make sure you remove includePaths from your ember-cli-build.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants