The return of simple_cache_middleware #3436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KPrasch
added
Optimization
derekpierre
approved these changes
Feb 8, 2024
Merged
derekpierre
reviewed
Feb 8, 2024
| @@ -259,6 +259,9 @@ def attach_middleware(self): | |||
| self.log.debug('Injecting POA middleware at layer 0') | |||
| self.client.inject_middleware(geth_poa_middleware, layer=0) | |||
|
|
|||
| self.log.debug("Adding simple_cache_middleware") | |||
| self.client.add_middleware(simple_cache_middleware) | |||
Yeah, I thought about that too, but we'd be testing web3py. There's also no middlewares at the current TesterBlockchain level. |
KPrasch
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Required reviews:
What this does:
simple_cache_middlewareIssues fixed/closed:
Why it's needed:
Currently, TACo nodes exhibit a relatively high RPC requests consumption (see #3370). This is just a small improvement, mainly reducing repeated calls to
eth_chainId. For some reason, with v7.1.0 I've seen ~5,000 of these per day.Notes for reviewers:
We had to temporarily remove
simple_cache_middlewarewhen @KPrasch and I detected that it shared state between multiple Web3 instances (see ethereum/web3.py#2977 ). This was fixed by ethereum/web3.py#2979, and released in v6.5.0 (https://web3py.readthedocs.io/en/stable/releases.html#web3-py-v6-5-0-2023-06-15). We currently pin v6.14.0.