Cleanup

source/Nuke.Build.Shared/Constants.cs

@@ -16,6 +16,7 @@ namespace Nuke.Common;
 /// <summary>
 /// Set of constants shared between libraries and IDE extensions.
 /// </summary>
+[UsedImplicitly]
 internal static class Constants
 {
     internal const string NukeFileName = NukeDirectoryName;

source/Nuke.Build/Execution/ParameterService.cs

@@ -62,22 +62,22 @@ public static string GetParameterMemberName<T>(Expression<Func<T>> expression)
 
     public static string GetParameterMemberName(MemberInfo member)
     {
-        var attribute = member.GetCustomAttribute<ParameterAttribute>();
+        var attribute = member.GetCustomAttribute<ParameterAttribute>().NotNull();
         var prefix = member.DeclaringType.NotNull().GetCustomAttribute<ParameterPrefixAttribute>()?.Prefix;
         return prefix + (attribute.Name ?? member.Name);
     }
 
     [CanBeNull]
     public static string GetParameterDescription(MemberInfo member)
     {
-        var attribute = member.GetCustomAttribute<ParameterAttribute>();
+        var attribute = member.GetCustomAttribute<ParameterAttribute>().NotNull();
         return attribute.Description?.TrimEnd('.');
     }
 
     [CanBeNull]
     public static IEnumerable<(string Text, object Object)> GetParameterValueSet(MemberInfo member, object instance)
     {
-        var attribute = member.GetCustomAttribute<ParameterAttribute>();
+        var attribute = member.GetCustomAttribute<ParameterAttribute>().NotNull();
         var memberType = member.GetMemberType().GetScalarType();
 
         IEnumerable<(string Text, object Object)> TryGetFromValueProvider()
@@ -131,7 +131,7 @@ public static string GetParameterDescription(MemberInfo member)
     [CanBeNull]
     public static object GetFromMemberInfo(MemberInfo member, [CanBeNull] Type destinationType, Func<string, Type, char?, object> provider)
     {
-        var attribute = member.GetCustomAttribute<ParameterAttribute>();
+        var attribute = member.GetCustomAttribute<ParameterAttribute>().NotNull();
         var separator = (attribute.Separator ?? string.Empty).SingleOrDefault();
         return provider.Invoke(GetParameterMemberName(member), destinationType ?? member.GetMemberType(), separator);
     }

source/Nuke.Build/Host.Activation.cs

@@ -7,11 +7,13 @@
 using System.ComponentModel;
 using System.Globalization;
 using System.Linq;
+using JetBrains.Annotations;
 using Nuke.Common.Execution;
 using Nuke.Common.Utilities;
 
 namespace Nuke.Common;
 
+[UsedImplicitly(ImplicitUseKindFlags.InstantiatedNoFixedConstructorSignature)]
 public partial class Host
 {
     internal static Host Instance { get; private set; }

source/Nuke.Build/INukeBuild.cs

@@ -14,6 +14,7 @@
 
 namespace Nuke.Common;
 
+[PublicAPI]
 public interface INukeBuild
 {
     void ReportSummary(Configure<IDictionary<string, string>> configurator = null);

source/Nuke.Build/Terminal.cs

@@ -4,17 +4,20 @@
 
 using System;
 using System.Linq;
+using JetBrains.Annotations;
 using Nuke.Common.Utilities;
 
 namespace Nuke.Common.Execution;
 
 public class Terminal : Host
 {
+    [UsedImplicitly]
     public static bool IsRunningTerminal => true;
 }
 
 public class Rider : Terminal
 {
+    [UsedImplicitly]
     internal static bool IsRunningRider
         => !Environment.GetEnvironmentVariable("IDEA_INITIAL_DIRECTORY").IsNullOrEmpty() ||
            (Environment.GetEnvironmentVariable("XPC_SERVICE_NAME")?.ContainsOrdinalIgnoreCase("com.jetbrains.rider") ?? false) ||
@@ -23,13 +26,15 @@ internal static bool IsRunningRider
 
 public class VSCode : Terminal
 {
+    [UsedImplicitly]
     internal static bool IsRunningVSCode
         => !Environment.GetEnvironmentVariable("VSCODE_GIT_IPC_HANDLE").IsNullOrEmpty() ||
            !Environment.GetEnvironmentVariable("VSCODE_PID").IsNullOrEmpty();
 }
 
 public class VisualStudio : Terminal
 {
+    [UsedImplicitly]
     internal static bool IsRunningVisualStudio
         => !Environment.GetEnvironmentVariable("VisualStudioVersion").IsNullOrEmpty();
 }

source/Nuke.Common/CI/AppVeyor/AppVeyor.cs

@@ -39,6 +39,7 @@ public partial class AppVeyor : Host, IBuildServer
 
     public static int MessageLimit = 500;
 
+    [UsedImplicitly]
     internal static bool IsRunningAppVeyor => EnvironmentInfo.HasVariable("APPVEYOR");
 
     private readonly Lazy<Tool> _cli = Lazy.Create(() => IsRunningAppVeyor ? ToolResolver.GetEnvironmentOrPathTool("appveyor") : null);

source/Nuke.Common/CI/AzurePipelines/AzurePipelines.cs

@@ -22,6 +22,7 @@ public partial class AzurePipelines : Host, IBuildServer
 {
     public new static AzurePipelines Instance => Host.Instance as AzurePipelines;
 
+    [UsedImplicitly]
     internal static bool IsRunningAzurePipelines => EnvironmentInfo.HasVariable("TF_BUILD");
 
     private readonly Action<string> _messageSink;

source/Nuke.Common/CI/Bamboo/Bamboo.cs

@@ -18,6 +18,7 @@ public class Bamboo : Host, IBuildServer
 {
     public new static Bamboo Instance => Host.Instance as Bamboo;
 
+    [UsedImplicitly]
     internal static bool IsRunningBamboo => EnvironmentInfo.HasVariable("bamboo_planKey");
 
     internal Bamboo()

source/Nuke.Common/CI/Bitbucket/Bitbucket.cs

@@ -19,6 +19,7 @@ public class Bitbucket : Host, IBuildServer
 {
     public new static Bitbucket Instance => Host.Instance as Bitbucket;
 
+    [UsedImplicitly]
     internal static bool IsRunningBitbucket => EnvironmentInfo.HasVariable("BITBUCKET_PIPELINE_UUID");
 
     internal Bitbucket()

source/Nuke.Common/CI/Bitrise/Bitrise.cs

@@ -18,6 +18,7 @@ public class Bitrise : Host, IBuildServer
 {
     public new static Bitrise Instance => Host.Instance as Bitrise;
 
+    [UsedImplicitly]
     internal static bool IsRunningBitrise => EnvironmentInfo.HasVariable("BITRISE_BUILD_URL");
 
     private static DateTime ConvertUnixTimestamp(long timestamp)

source/Nuke.Common/CI/GitHubActions/GitHubActions.cs

@@ -26,6 +26,7 @@ namespace Nuke.Common.CI.GitHubActions;
 [ExcludeFromCodeCoverage]
 public partial class GitHubActions : Host, IBuildServer
 {
+    [UsedImplicitly]
     internal static bool IsRunningGitHubActions => EnvironmentInfo.HasVariable("GITHUB_ACTIONS");
 
     public new static GitHubActions Instance => Host.Instance as GitHubActions;

source/Nuke.Common/CI/GitLab/GitLab.cs

@@ -20,6 +20,7 @@ public partial class GitLab : Host, IBuildServer
 {
     public new static GitLab Instance => Host.Instance as GitLab;
 
+    [UsedImplicitly]
     internal static bool IsRunningGitLab => EnvironmentInfo.HasVariable("GITLAB_CI");
 
     private const string SectionStartSequence = "\u001b[0K";

source/Nuke.Common/CI/Jenkins/Jenkins.cs

@@ -19,6 +19,7 @@ public class Jenkins : Host, IBuildServer
 {
     public new static Jenkins Instance => Host.Instance as Jenkins;
 
+    [UsedImplicitly]
     internal static bool IsRunningJenkins => EnvironmentInfo.HasVariable("JENKINS_HOME");
 
     internal Jenkins()

source/Nuke.Common/CI/SpaceAutomation/SpaceAutomation.cs

@@ -19,6 +19,7 @@ public partial class SpaceAutomation : Host, IBuildServer
 {
     public new static SpaceAutomation Instance => Host.Instance as SpaceAutomation;
 
+    [UsedImplicitly]
     internal static bool IsRunningSpaceAutomation => EnvironmentInfo.HasVariable("JB_SPACE_PROJECT_KEY");
 
     string IBuildServer.Branch => GitBranch;

source/Nuke.Common/CI/TeamCity/TeamCity.cs

@@ -26,6 +26,7 @@ public partial class TeamCity : Host, IBuildServer
 {
     public new static TeamCity Instance => Host.Instance as TeamCity;
 
+    [UsedImplicitly]
     internal static bool IsRunningTeamCity => EnvironmentInfo.HasVariable("TEAMCITY_VERSION");
 
     [CanBeNull]

source/Nuke.Common/CI/TeamCity/TeamCityAttribute.cs

@@ -275,7 +275,7 @@ protected virtual TeamCityParameter GetParameter(MemberInfo member, bool require
     {
         var attribute = member.GetCustomAttribute<ParameterAttribute>();
         var valueSet = ParameterService.GetParameterValueSet(member, Build);
-        var valueSeparator = attribute.Separator ?? " ";
+        var valueSeparator = attribute.NotNull().Separator ?? " ";
 
         // TODO: Abstract AbsolutePath/Solution/Project etc.
         var defaultValue = !member.HasCustomAttribute<SecretAttribute>() ? member.GetValue(Build) : default(string);
@@ -284,7 +284,7 @@ protected virtual TeamCityParameter GetParameter(MemberInfo member, bool require
             (member.GetMemberType() == typeof(AbsolutePath) ||
              member.GetMemberType() == typeof(Solution) ||
              member.GetMemberType() == typeof(Project)))
-            defaultValue = (UnixRelativePath) GetRelativePath(Build.RootDirectory, defaultValue.ToString());
+            defaultValue = Build.RootDirectory.GetUnixRelativePathTo(defaultValue.ToString());
 
         TeamCityParameterType GetParameterType()
         {

source/Nuke.Common/CI/TravisCI/TravisCI.cs

@@ -18,6 +18,7 @@ public partial class TravisCI : Host, IBuildServer
 {
     public new static TravisCI Instance => Host.Instance as TravisCI;
 
+    [UsedImplicitly]
     internal static bool IsRunningTravisCI => EnvironmentInfo.HasVariable("TRAVIS");
 
     internal TravisCI()

source/Nuke.Common/ChangeLog/ChangeLogTasks.cs

@@ -83,7 +83,7 @@ public static ChangeLog ReadChangelog(string changelogFile)
             return new ChangeLog(changelogFile, unreleased.First(), releaseNotes);
         }
 
-        Assert.True(releaseNotes.Count(x => !x.Unreleased) >= 1, "Changelog should have at lease one released version section");
+        Assert.True(releaseNotes.Any(x => !x.Unreleased), "Changelog should have at lease one released version section");
         return new ChangeLog(changelogFile, releaseNotes);
     }
 
@@ -178,11 +178,6 @@ internal static IEnumerable<ReleaseSection> GetReleaseSections(List<string> cont
         static bool IsReleaseHead(string str)
             => str.StartsWith("## ");
 
-        static bool IsReleaseContent(string str) => str.StartsWith("###")
-                                                    || str.Trim().StartsWith("-")
-                                                    || str.Trim().StartsWith("*")
-                                                    || str.Trim().StartsWith("+");
-
         static string GetCaption(string str)
             => str
                 .TrimStart('#', ' ', '[')

source/Nuke.GlobalTool/Program.cs

@@ -73,14 +73,13 @@ private static int Handle(string[] args, [CanBeNull] AbsolutePath rootDirectory,
                 Assert.Fail($"No command specified. Usage is: nuke {CommandPrefix}<command> [args]");
 
             var availableCommands = typeof(Program).GetMethods(ReflectionUtility.Static).Where(x => x.ReturnType == typeof(int)).ToList();
-            var commandHandler = availableCommands.SingleOrDefault(x => x.Name.EqualsOrdinalIgnoreCase(command));
-            Assert.NotNull(commandHandler,
-                new[] { $"Command '{command}' is not supported, available commands are:" }
+            var commandHandler = availableCommands.SingleOrDefault(x => x.Name.EqualsOrdinalIgnoreCase(command))
+                .NotNull(new[] { $"Command '{command}' is not supported, available commands are:" }
                     .Concat(availableCommands.Where(x => x.IsPublic).Select(x => $"  - {x.Name}").OrderBy(x => x)).JoinNewLine());
             // TODO: add assertions about return type and parameters
 
             var commandArguments = new object[] { args.Skip(count: 1).ToArray(), rootDirectory, buildScript };
-            return (int)commandHandler.Invoke(obj: null, commandArguments);
+            return (int)commandHandler.Invoke(obj: null, commandArguments).NotNull($"Command '{command}' did not return exit code");
         }
 
         if (rootDirectory == null || buildScript == null)

source/Nuke.MSBuildTasks/CodeGenerationTask.cs

@@ -16,10 +16,10 @@ namespace Nuke.MSBuildTasks;
 [UsedImplicitly]
 public class CodeGenerationTask : ContextAwareTask
 {
-    [Microsoft.Build.Framework.Required]
+    [Required]
     public ITaskItem[] SpecificationFiles { get; set; }
 
-    [Microsoft.Build.Framework.Required]
+    [Required]
     public string BaseDirectory { get; set; }
 
     public bool UseNestedNamespaces { get; set; }

source/Nuke.SolutionModel/Project.cs

@@ -46,5 +46,5 @@ public override string ToString()
         return Path;
     }
 
-    internal override string RelativePath => PathConstruction.GetRelativePath(Solution.Directory, Path);
+    internal override string RelativePath => Solution.Directory.GetRelativePathTo(Path);
 }

source/Nuke.SolutionModel/Solution.cs

@@ -225,7 +225,7 @@ SolutionFolder GetParentFolder(PrimitiveProject solutionFolder) =>
 
         IDictionary<string, string> GetItems(SolutionFolder solutionFolder)
             => solutionFolder.Items.Keys
-                .Select(x => (string) PathConstruction.GetWinRelativePath(Directory, solution.Directory / x))
+                .Select(x => (string) Directory.GetWinRelativePathTo(solution.Directory / x))
                 .ToDictionary(x => x, x => x);
 
         solution.AllSolutionFolders.ForEach(x => AddSolutionFolder(x.Name, x.ProjectId, GetParentFolder(x) ?? folder));

source/Nuke.SolutionModel/SolutionFolder.cs

@@ -32,12 +32,18 @@ public SolutionFolder(
     public IReadOnlyCollection<SolutionFolder> SolutionFolders => Solution.AllSolutionFolders.Where(x => x.SolutionFolder == this).ToList();
     public IReadOnlyCollection<Project> Projects => Solution.AllProjects.Where(x => x.SolutionFolder == this).ToList();
 
+    /// <summary>
+    /// Gets a solution folder by its name.
+    /// </summary>
     [CanBeNull]
     public SolutionFolder GetSolutionFolder(string name)
     {
         return SolutionFolders.SingleOrDefault(x => name.Equals(x.Name, StringComparison.Ordinal));
     }
 
+    /// <summary>
+    /// Gets a project by its name.
+    /// </summary>
     [CanBeNull]
     public Project GetProject(string name)
     {

source/Nuke.Tooling/Arguments.cs

@@ -11,6 +11,7 @@
 
 namespace Nuke.Common.Tooling;
 
+[PublicAPI]
 public interface IArguments
 {
     string FilterSecrets(string text);
@@ -19,6 +20,7 @@ public interface IArguments
 }
 
 // TODO: extract {value} and {key} into constants
+[PublicAPI]
 public sealed class Arguments : IArguments
 {
     internal const string Redacted = "[REDACTED]";

source/Nuke.Tooling/ToolingExtensions.cs

@@ -4,11 +4,13 @@
 
 using System;
 using System.Linq;
+using JetBrains.Annotations;
 using Nuke.Common.IO;
 using Nuke.Common.Utilities.Collections;
 
 namespace Nuke.Common.Tooling;
 
+[PublicAPI]
 public static class ToolingExtensions
 {
     public static AbsolutePath SetExecutable(this AbsolutePath path, bool updateVcsIndex = false)

source/Nuke.Utilities/EnvironmentInfo.Platform.cs

@@ -85,7 +85,7 @@ public static bool IsWsl
     /// Indicates the target framework of the current process.
     /// </summary>
     public static FrameworkName Framework
-        => new(Assembly.GetEntryAssembly().NotNull().GetCustomAttribute<TargetFrameworkAttribute>().FrameworkName);
+        => new(Assembly.GetEntryAssembly().NotNull().GetCustomAttribute<TargetFrameworkAttribute>().NotNull().FrameworkName);
 
     /// <summary>
     /// Indicates the operating-system platform.

source/Nuke.Utilities/Reflection/Assembly.Versioning.cs

@@ -24,6 +24,6 @@ public static string GetVersionText(this Assembly assembly)
 
     private static string GetAssemblyInformationalVersion(this Assembly assembly)
     {
-        return assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>().InformationalVersion;
+        return assembly.GetCustomAttribute<AssemblyInformationalVersionAttribute>().NotNull().InformationalVersion;
     }
 }

source/Nuke.Utilities/Reflection/ReflectionUtility.Invocation.cs

@@ -37,7 +37,7 @@ public static TResult GetValueNonVirtual<TResult>(this MemberInfo member, object
     {
         Assert.True(member is PropertyInfo or MethodInfo);
         var method = member is PropertyInfo property
-            ? property.GetMethod
+            ? property.GetMethod.NotNull()
             : (MethodInfo) member;
 
         var funcType = Expression.GetFuncType(method.GetParameters().Select(x => x.ParameterType)
@@ -87,7 +87,7 @@ public static void SetValue(this MemberInfo member, object instance, object valu
             else
             {
                 Assert.True(property.SetMethod != null, $"Property '{member.Name}' is not settable");
-                property.SetValue(property.GetMethod.IsStatic ? null : instance, value);
+                property.SetValue(property.IsStatic() ? null : instance, value);
             }
         }
     }