Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions of generated GitHub Actions tasks #1031

Merged
merged 3 commits into from
Dec 12, 2022
Merged

Update versions of generated GitHub Actions tasks #1031

merged 3 commits into from
Dec 12, 2022

Conversation

esond
Copy link
Contributor

@esond esond commented Oct 11, 2022

This updates the versions of the generated cache and checkout tasks for GitHub Actions. The currently generated tasks are deprecated and result in a warning that reads something like:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: actions/checkout, actions/cache

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

@Simonl9l
Copy link

Simonl9l commented Nov 5, 2022

FYI there is current a bug in checkout that means its not correctly pulling tags when FetchDepth:0.

There is a workaround not sure how this could be factored in.

@Simonl9l
Copy link

Simonl9l commented Nov 7, 2022

Just popped up on GitHub Workflows...
image

@@ -17,7 +17,7 @@ public class GitHubActionsCheckoutStep : GitHubActionsStep

public override void Write(CustomFileWriter writer)
{
writer.WriteLine("- uses: actions/checkout@v2");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be beneficial for the actions/checkout@v2 part to be public get/set property to allow people to override in their own pipelines when needed if yet another update comes in?

It would then be just a matter of finding with type and then setting the value to something else.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same goes for the actions/upload-artifact@v3 too if that makes sense.

@matkoch matkoch force-pushed the develop branch 3 times, most recently from a5d109e to e2e1e13 Compare November 30, 2022 01:42
@matkoch matkoch force-pushed the develop branch 12 times, most recently from d1105a4 to 73ea8ba Compare December 6, 2022 14:08
@matkoch matkoch force-pushed the develop branch 3 times, most recently from d4197bd to becd412 Compare December 12, 2022 22:01
@matkoch matkoch merged commit 6a5487d into nuke-build:develop Dec 12, 2022
@matkoch matkoch added this to the v6.2.2 milestone Dec 12, 2022
@esond esond deleted the update-github-action-versions branch May 1, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants