Added Docker CliSettings context and host, along with extensions #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matkoch
force-pushed
the
develop
branch
5 times, most recently
from
0231425
to
d806295
Compare
matkoch
force-pushed
the
develop
branch
3 times, most recently
from
7066bbe
to
985de83
Compare
matkoch
force-pushed
the
develop
branch
4 times, most recently
from
0719711
to
6fe1e3b
Compare
matkoch
force-pushed
the
develop
branch
2 times, most recently
from
6d02194
to
4bfee84
Compare
matkoch
force-pushed
the
develop
branch
4 times, most recently
from
85998da
to
01b2b6e
Compare
matkoch
force-pushed
the
develop
branch
3 times, most recently
from
e652c9a
to
6ed9e4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Removing the ProcessLogger from CliSettings could have done the trick, to avoid NewInstance throwing while copying the logger. However it seems the exception there was on purpose, to prevent people from using the logger in the common type. So I modified a little bit the tool code generation to support not deriving from ToolSettings, which removes the extra ProcessLogger and makes NewInstance not try to copy anything. I think it makes everything cleaner, not sure what you had in mind at the beginning ...
It was partially tested in our solution, I was able to remove all hacks to set CliSettings properties. I was not able to do a full build though as our CI is currently broken ...
I confirm that the pull-request: