Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Chore: run in sdks-e2e tests, python-udsink log check before go-udsink (
#315) This change attempts to fix E2E test failure scenario 3 in #210 (comment) Every once in a while(about one occurrence every ~10 executions) our sdks-e2e tests fail with log validation error. The error is always thrown by VertexPodLogContains check and it's always thrown by the python-udsink, never go-udsink. Looking at the log, I can see the failure was caused by context being closed before our default timeout. I suspect the reason why it's always python-udsink, could be because python-udsink is the very last check of the E2E test and the github E2E test infrastructure could terminate the test early before tests are done. To verify my hypothesis, I made this code change to see if I can get a failure from go-udsink. Magically after this change, the error is gone. I tested it by running the E2E tests for 25+ times. I still don't know why making this switch helps remove the failure. But I hope pushing this out could help reduce a little bit of manual rerun efforts. Signed-off-by: Keran Yang <[email protected]>
- Loading branch information