fix(manifests): Include ServiceAccount in namespace scoped install (#240

)

Signed-off-by: Derek Wang <[email protected]>

config/advanced-install/namespaced-controller-wo-crds.yaml

@@ -1,8 +1,12 @@
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: numaflow-sa
+---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
   name: numaflow-role
-  namespace: numaflow-system
 rules:
 - apiGroups:
   - numaflow.numaproj.io
@@ -73,7 +77,6 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   name: numaflow-role-binding
-  namespace: numaflow-system
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
@@ -190,13 +193,11 @@ data:
 kind: ConfigMap
 metadata:
   name: numaflow-controller-config
-  namespace: numaflow-system
 ---
 apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: numaflow-controller
-  namespace: numaflow-system
 spec:
   replicas: 1
   selector:

config/advanced-install/namespaced-controller/kustomization.yaml

@@ -9,8 +9,6 @@ resources:
   - ../../base/controller-manager
   - ../../namespace-install/rbac/controller-manager
 
-namespace: numaflow-system
-
 images:
   - name: quay.io/numaproj/numaflow
     newTag: v0.6.0

config/advanced-install/numaflow-server.yaml

@@ -1,3 +1,9 @@
+apiVersion: v1
+kind: ServiceAccount
+metadata:
+  name: numaflow-server-sa
+  namespace: numaflow-system
+---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRole
 metadata:

config/base/controller-manager/kustomization.yaml

@@ -2,5 +2,6 @@ apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 
 resources:
+  - numaflow-sa.yaml
   - numaflow-controller-config.yaml
   - controller-manager-deployment.yaml

config/base/kustomization.yaml

@@ -3,8 +3,6 @@ kind: Kustomization
 
 resources:
   - crds/full
-  - numaflow-sa.yaml
-  - numaflow-server-sa.yaml
   - controller-manager
   - numaflow-server
 

config/base/numaflow-server/kustomization.yaml

@@ -2,5 +2,6 @@ apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 
 resources:
+  - numaflow-server-sa.yaml
   - numaflow-server-deployment.yaml
-  - numaflow-server-service.yaml
+  - numaflow-server-service.yaml

config/namespace-install.yaml

@@ -12614,19 +12614,16 @@ apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: numaflow-sa
-  namespace: numaflow-system
 ---
 apiVersion: v1
 kind: ServiceAccount
 metadata:
   name: numaflow-server-sa
-  namespace: numaflow-system
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
   name: numaflow-role
-  namespace: numaflow-system
 rules:
 - apiGroups:
   - numaflow.numaproj.io
@@ -12697,7 +12694,6 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: Role
 metadata:
   name: numaflow-server-role
-  namespace: numaflow-system
 rules:
 - apiGroups:
   - numaflow.numaproj.io
@@ -12751,29 +12747,25 @@ apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   name: numaflow-role-binding
-  namespace: numaflow-system
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
   name: numaflow-role
 subjects:
 - kind: ServiceAccount
   name: numaflow-sa
-  namespace: numaflow-system
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: RoleBinding
 metadata:
   name: numaflow-server-binding
-  namespace: numaflow-system
 roleRef:
   apiGroup: rbac.authorization.k8s.io
   kind: Role
   name: numaflow-server-role
 subjects:
 - kind: ServiceAccount
   name: numaflow-server-sa
-  namespace: numaflow-system
 ---
 apiVersion: v1
 data:
@@ -12883,13 +12875,11 @@ data:
 kind: ConfigMap
 metadata:
   name: numaflow-controller-config
-  namespace: numaflow-system
 ---
 apiVersion: v1
 kind: Service
 metadata:
   name: numaflow-server
-  namespace: numaflow-system
 spec:
   ports:
   - port: 8443
@@ -12903,7 +12893,6 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: numaflow-controller
-  namespace: numaflow-system
 spec:
   replicas: 1
   selector:
@@ -12965,7 +12954,6 @@ apiVersion: apps/v1
 kind: Deployment
 metadata:
   name: numaflow-server
-  namespace: numaflow-system
 spec:
   replicas: 1
   selector:

config/namespace-install/kustomization.yaml

@@ -5,8 +5,6 @@ resources:
   - ../base
   - rbac
 
-namespace: numaflow-system
-
 patches:
   - patch: |-
       - op: add

config/namespace-install/rbac/numaflow-server/numaflow-server-binding.yaml

@@ -9,4 +9,3 @@ roleRef:
 subjects:
   - kind: ServiceAccount
     name: numaflow-server-sa
-    namespace: numaflow-system

docs/installation.md

@@ -57,8 +57,6 @@ resources:
 namespace: numaflow-system
 ```
 
-**Note**: Currently namespace scoped installaion only applies to the controller deployment, the `numaflow-server` (User Interface) deployment still remains cluster scoped installation.
-
 ## Managed Namespace Scope
 
 A managed namespace installation watches and executes pipelines in a specific namespace.

mkdocs.yml

@@ -80,4 +80,4 @@ nav:
       - debugging.md
       - static-code-analysis.md
       - releasing.md
-  - Numaproj: https://www.numaproj.io
+  - Numaproj: https://numaproj.io