Skip to content

Commit

Permalink
fix spelling errors (#48)
Browse files Browse the repository at this point in the history
Signed-off-by: Qianbo Huai <[email protected]>
  • Loading branch information
qhuai authored Jun 6, 2022
1 parent f423002 commit 9f9f5ba
Show file tree
Hide file tree
Showing 9 changed files with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -1253,7 +1253,7 @@ spec:
type: object
encryption:
description: Whether encrypt the data at rest, defaults to false
Enabling encryption might impact the performace, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest
Enabling encryption might impact the performance, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest
for the detail Toggling the value will impact encypting/decrypting
existing messages.
type: boolean
Expand Down Expand Up @@ -2181,7 +2181,7 @@ spec:
type: array
tls:
description: Whether enable TLS, defaults to false Enabling TLS
might impact the performace
might impact the performance
type: boolean
tolerations:
description: If specified, the pod's tolerations.
Expand Down
4 changes: 2 additions & 2 deletions config/install.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1252,7 +1252,7 @@ spec:
type: object
encryption:
description: Whether encrypt the data at rest, defaults to false
Enabling encryption might impact the performace, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest
Enabling encryption might impact the performance, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest
for the detail Toggling the value will impact encypting/decrypting
existing messages.
type: boolean
Expand Down Expand Up @@ -2180,7 +2180,7 @@ spec:
type: array
tls:
description: Whether enable TLS, defaults to false Enabling TLS
might impact the performace
might impact the performance
type: boolean
tolerations:
description: If specified, the pod's tolerations.
Expand Down
4 changes: 2 additions & 2 deletions controllers/pipeline/validate.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,11 @@ func ValidatePipeline(pl *dfv1.Pipeline) error {
}

if len(sources) == 0 {
return fmt.Errorf("pipeline has no source, at lease one vertex with 'source' defined is requried")
return fmt.Errorf("pipeline has no source, at lease one vertex with 'source' defined is required")
}

if len(sinks) == 0 {
return fmt.Errorf("pipeline has no sink, at lease one vertex with 'sink' defined is requried")
return fmt.Errorf("pipeline has no sink, at lease one vertex with 'sink' defined is required")
}

for k, u := range udfs {
Expand Down
4 changes: 2 additions & 2 deletions docs/APIs.md
Original file line number Diff line number Diff line change
Expand Up @@ -1612,7 +1612,7 @@ fields under “otBucket” include “maxValueSize”, “history”, “ttl”
<em>(Optional)</em>
<p>
Whether encrypt the data at rest, defaults to false Enabling encryption
might impact the performace, see
might impact the performance, see
<a href="https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest">https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest</a>
for the detail Toggling the value will impact encypting/decrypting
existing messages.
Expand All @@ -1627,7 +1627,7 @@ existing messages.
<em>(Optional)</em>
<p>
Whether enable TLS, defaults to false Enabling TLS might impact the
performace
performance
</p>
</td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions pkg/apis/numaflow/v1alpha1/generated.proto

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions pkg/apis/numaflow/v1alpha1/jetstream_buffer_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,12 +93,12 @@ type JetStreamBufferService struct {
// +optional
BufferConfig *string `json:"bufferConfig,omitempty" protobuf:"bytes,18,opt,name=bufferConfig"`
// Whether encrypt the data at rest, defaults to false
// Enabling encryption might impact the performace, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest for the detail
// Enabling encryption might impact the performance, see https://docs.nats.io/running-a-nats-service/nats_admin/jetstream_admin/encryption_at_rest for the detail
// Toggling the value will impact encypting/decrypting existing messages.
// +optional
Encryption bool `json:"encryption,omitempty" protobuf:"bytes,19,opt,name=encryption"`
// Whether enable TLS, defaults to false
// Enabling TLS might impact the performace
// Enabling TLS might impact the performance
// +optional
TLS bool `json:"tls,omitempty" protobuf:"bytes,20,opt,name=tls"`
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/isb/redis/read.go
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ func (br *BufferRead) Read(_ context.Context, count int64) ([]*isb.ReadMessage,
return messages, fmt.Errorf("XReadGroup failed, %w", err)
}

// NOTE: If all messages have been delivered and acknowleged, the XREADGROUP 0-0 call returns an empty
// NOTE: If all messages have been delivered and acknowledged, the XREADGROUP 0-0 call returns an empty
// list of messages in the stream. At this point we want to read everything from last delivered which would be >
if len(xstreams) == 1 && len(xstreams[0].Messages) == 0 {
br.log.Infow("We have delivered and acknowledged all PENDING msgs, setting checkBacklog to false")
Expand Down
2 changes: 1 addition & 1 deletion pkg/isb/redis/write.go
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ func (bw *BufferWrite) refreshWriteInfo(ctx context.Context) {
}
}

// trim is used to explicity call TRIM on buffer being full
// trim is used to explicitly call TRIM on buffer being full
func (bw *BufferWrite) trim(_ context.Context) {
ctx := clients.RedisContext
bw.log.Infow("Explicit trim on MINID", zap.String("MINID", bw.minId.Load()))
Expand Down
4 changes: 2 additions & 2 deletions pkg/sources/kafka/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ var kafkaSourceReadCount = promauto.NewCounterVec(prometheus.CounterOpts{
Help: "Total number of messages Read",
}, []string{"vertex", "pipeline"})

// kafkaSourceAckCount is used to indicate the number of messages Acknowleged
// kafkaSourceAckCount is used to indicate the number of messages Acknowledged
var kafkaSourceAckCount = promauto.NewCounterVec(prometheus.CounterOpts{
Subsystem: "kafka_source",
Name: "ack_total",
Help: "Total number of messages Acknowleged",
Help: "Total number of messages Acknowledged",
}, []string{"vertex", "pipeline"})

// kafkaSourceOffsetAckErrors is used to indicate the number of errors while reading from kafka source with offsets
Expand Down

0 comments on commit 9f9f5ba

Please sign in to comment.