fix: treat ALL user-defined source vertices as scalable (#1132)

Signed-off-by: Keran Yang <[email protected]>
numaproj · Oct 2, 2023 · a7adee1 · a7adee1
1 parent 408ff38
commit a7adee1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/pkg/apis/numaflow/v1alpha1/vertex_types.go b/pkg/apis/numaflow/v1alpha1/vertex_types.go
@@ -114,7 +114,7 @@ func (v Vertex) Scalable() bool {
 	}
 	if v.IsASource() {
 		src := v.Spec.Source
-		if src.Kafka != nil {
+		if src.Kafka != nil || src.UDSource != nil {
 			return true
 		}
 	}

diff --git a/pkg/apis/numaflow/v1alpha1/vertex_types_test.go b/pkg/apis/numaflow/v1alpha1/vertex_types_test.go
@@ -535,6 +535,10 @@ func TestScalable(t *testing.T) {
 		Kafka: &KafkaSource{},
 	}
 	assert.True(t, v.Scalable())
+	v.Spec.Source = &Source{
+		UDSource: &UDSource{},
+	}
+	assert.True(t, v.Scalable())
 }
 
 func Test_Scale_Parameters(t *testing.T) {