Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: source to sink with an optional transformer without ISB #1904

Merged
merged 18 commits into from
Aug 9, 2024

Conversation

vigith
Copy link
Member

@vigith vigith commented Aug 6, 2024

Source to Sink via an optional transformer without ISB.

Manual Testing

apiVersion: numaflow.numaproj.io/v1alpha1
kind: MonoVertex
metadata:
  name: ceres-mono-vertex
spec:
  replicas: 5
  source:
    udsource:
      container:
        image: docker.xxx.com/eventbus-numaflow:0.5.1
        args:
          - --spring.config.location=file:/conf/eventbus-source-config.yaml
          - --numaflow.handler=eventbus-source
        env:
          - name: config_file_path
            value: /conf/eventbus-source-config.yaml
        volumeMounts:
          - name: eventbus-source-config-volume
            mountPath: /conf

  sink:
    udsink:
      container:
        image: docker.xxx.com/blackhole-sink:stable

  volumes:
    - name: eventbus-source-config-volume
      configMap:
        name: eventbus-source-config
        items:
          - key: configuration
            path: eventbus-source-config.yaml

Signed-off-by: Vigith Maurice <[email protected]>
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 29.50820% with 43 lines in your changes missing coverage. Please review.

Project coverage is 58.26%. Comparing base (eb2717e) to head (ad6bc66).

Files Patch % Lines
serving/source-sink/src/source.rs 30.50% 41 Missing ⚠️
pkg/apis/numaflow/v1alpha1/mono_vertex_types.go 0.00% 1 Missing ⚠️
serving/source-sink/src/message.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1904      +/-   ##
==========================================
+ Coverage   58.18%   58.26%   +0.07%     
==========================================
  Files         291      293       +2     
  Lines       24381    24351      -30     
==========================================
+ Hits        14186    14187       +1     
+ Misses       9260     9230      -30     
+ Partials      935      934       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith vigith changed the title feat: source to sink with optional an transformer without ISB feat: source to sink with an optional transformer without ISB Aug 7, 2024
Signed-off-by: Yashash H L <[email protected]>
vigith and others added 4 commits August 7, 2024 18:17
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
@vigith vigith marked this pull request as ready for review August 9, 2024 18:28
@vigith vigith requested a review from whynowy as a code owner August 9, 2024 18:28

####################################################################################################
# numaflow
####################################################################################################
ARG BASE_IMAGE
FROM ${BASE_IMAGE} as numaflow
FROM debian:bookworm as numaflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going out of control.

  1. Image build time in the CI increased from <2 mins to > 7 mins
  2. Image size and security vulunabilities.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can handle this in follow up PR, already created an action item.

.build_server(true)
.compile(
&[
"proto/source.proto",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason the client needs to keep the proto files?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do not need to, we can copy at build time. this was the reason for #1910

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we will handle this in follow up PR.

@vigith vigith marked this pull request as draft August 9, 2024 19:20
@vigith
Copy link
Member Author

vigith commented Aug 9, 2024

i am reviewing this PR, please do not merge.

@vigith vigith marked this pull request as ready for review August 9, 2024 20:00
@vigith vigith merged commit c399d05 into main Aug 9, 2024
25 checks passed
@vigith vigith deleted the sourcer-sinker branch August 9, 2024 20:01
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Aug 14, 2024
…oj#1904)

Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Co-authored-by: Yashash H L <[email protected]>
Co-authored-by: Sidhant Kohli <[email protected]>
KeranYang pushed a commit that referenced this pull request Aug 19, 2024
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Co-authored-by: Yashash H L <[email protected]>
Co-authored-by: Sidhant Kohli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants