-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: source to sink with an optional transformer without ISB #1904
Conversation
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1904 +/- ##
==========================================
+ Coverage 58.18% 58.26% +0.07%
==========================================
Files 291 293 +2
Lines 24381 24351 -30
==========================================
+ Hits 14186 14187 +1
+ Misses 9260 9230 -30
+ Partials 935 934 -1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]>
Signed-off-by: Sidhant Kohli <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
Signed-off-by: Yashash H L <[email protected]>
|
||
#################################################################################################### | ||
# numaflow | ||
#################################################################################################### | ||
ARG BASE_IMAGE | ||
FROM ${BASE_IMAGE} as numaflow | ||
FROM debian:bookworm as numaflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going out of control.
- Image build time in the CI increased from
<2 mins
to> 7 mins
- Image size and security vulunabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can handle this in follow up PR, already created an action item.
.build_server(true) | ||
.compile( | ||
&[ | ||
"proto/source.proto", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason the client needs to keep the proto files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not need to, we can copy at build time. this was the reason for #1910
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we will handle this in follow up PR.
i am reviewing this PR, please do not merge. |
…oj#1904) Signed-off-by: Vigith Maurice <[email protected]> Signed-off-by: Yashash H L <[email protected]> Signed-off-by: Sidhant Kohli <[email protected]> Co-authored-by: Yashash H L <[email protected]> Co-authored-by: Sidhant Kohli <[email protected]>
Signed-off-by: Vigith Maurice <[email protected]> Signed-off-by: Yashash H L <[email protected]> Signed-off-by: Sidhant Kohli <[email protected]> Co-authored-by: Yashash H L <[email protected]> Co-authored-by: Sidhant Kohli <[email protected]>
Source to Sink via an optional transformer without ISB.
Manual Testing