Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rust codegen templates #1913

Merged
merged 5 commits into from
Aug 9, 2024
Merged

chore: rust codegen templates #1913

merged 5 commits into from
Aug 9, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Aug 9, 2024

Customize templates for rust models - to remove the version info from generated model files to avoid merging conflicts during release.

Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy requested a review from vigith as a code owner August 9, 2024 00:32
.
Signed-off-by: Derek Wang <[email protected]>
.
Signed-off-by: Derek Wang <[email protected]>
Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.16%. Comparing base (0933194) to head (a32e67a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1913      +/-   ##
==========================================
+ Coverage   58.07%   58.16%   +0.09%     
==========================================
  Files         291      291              
  Lines       24381    24381              
==========================================
+ Hits        14159    14181      +22     
+ Misses       9283     9266      -17     
+ Partials      939      934       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
@whynowy whynowy enabled auto-merge (squash) August 9, 2024 04:41
@whynowy whynowy merged commit 8e47d7f into numaproj:main Aug 9, 2024
25 checks passed
@whynowy whynowy deleted the codegen branch August 9, 2024 05:11
SaniyaKalamkar pushed a commit to SaniyaKalamkar/numaflow that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants