Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update udf fetchWatermark and publishWatermark initial values #193

Merged
merged 1 commit into from
Sep 29, 2022
Merged

fix: update udf fetchWatermark and publishWatermark initial values #193

merged 1 commit into from
Sep 29, 2022

Conversation

jy4096
Copy link
Contributor

@jy4096 jy4096 commented Sep 29, 2022 •
edited
Loading

fix: update udf fetchWatermark and publishWatermark initial values

tested using redis isbsvc and simple pipeline with

  watermark:
    disabled: true

image

image

@jy4096 jy4096 marked this pull request as ready for review September 29, 2022 23:42
whynowy
whynowy approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whynowy whynowy merged commit b1b78fa into numaproj:main Sep 29, 2022
@jy4096 jy4096 deleted the udf-watermark-fetcher-bug-fix branch October 11, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whynowy whynowy whynowy approved these changes

@vigith vigith Awaiting requested review from vigith vigith is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jy4096 @whynowy