Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): use manifests from main branch in quick-start #2197

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Nov 1, 2024

even-odd example in quick-start is broken due to the gRPC protocol change.

Switch to using main branch manifests for installation and quick-start examples, which should be always working.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.78%. Comparing base (f6dbe86) to head (285f4b1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2197      +/-   ##
==========================================
+ Coverage   63.76%   63.78%   +0.01%     
==========================================
  Files         334      334              
  Lines       40626    40626              
==========================================
+ Hits        25907    25912       +5     
+ Misses      13665    13656       -9     
- Partials     1054     1058       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KeranYang KeranYang merged commit 426141a into numaproj:main Nov 1, 2024
25 checks passed
@whynowy whynowy deleted the dfix branch November 1, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants