feat: block isbsvc deleting when there is linked pipeline #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek Wang <[email protected]>
Signed-off-by: Derek Wang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2202 +/- ##
=======================================
Coverage ? 63.93%
=======================================
Files ? 334
Lines ? 40676
Branches ? 0
=======================================
Hits ? 26006
Misses ? 13611
Partials ? 1059 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Derek Wang <[email protected]>
vigith
approved these changes
Nov 5, 2024
| return fmt.Errorf("failed to check if there is any pipeline using this InterStepBufferService, %w", err) | ||
| } | ||
| if pls > 0 { | ||
| return fmt.Errorf("can not delete InterStepBufferService %q which has %d pipelines connected", isbSvc.Name, pls) |
There was a problem hiding this comment.
will printing the pipeline names help the end user?
There was a problem hiding this comment.
This will show up in ISBService status, which means it displays in kubectl get isbsvc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should sort of fix the problem in #1956.