Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support running UX server with namespace scope. Fixes #248 #249

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

dseapy
Copy link
Contributor

@dseapy dseapy commented Oct 21, 2022

Signed-off-by: David Seapy [email protected]

Add support for running UX server restricted to a namespace.

@dseapy dseapy marked this pull request as ready for review October 21, 2022 01:51
Copy link
Member

@whynowy whynowy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I was thinking of raising an issue about this yesterday after making changes to the installation manifests, but you already submitted a PR for it!

logger := logging.NewLogger().Named("server")
router := gin.New()
router.Use(gin.Logger())
router.RedirectTrailingSlash = true
router.Use(static.Serve("/", static.LocalFile("./ui/build", true)))
if namespaced {
router.Use(Namespace(managedNamespace))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@whynowy whynowy merged commit 0370fd6 into numaproj:main Oct 21, 2022
@dseapy dseapy deleted the support-namespaced-server branch October 21, 2022 15:50
whynowy pushed a commit that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants