Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: generalize watermark fetching as an interface of ISB service. Fixes #252 #263

Merged
merged 11 commits into from
Oct 25, 2022
Merged

refactor: generalize watermark fetching as an interface of ISB service. Fixes #252 #263

merged 11 commits into from
Oct 25, 2022

Commits on Oct 24, 2022

  1. refactor: generalize watermark fetching as an interface of ISB service 

    Signed-off-by: Keran Yang <[email protected]>
    @KeranYang
    KeranYang committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    6b30082 View commit details
    Browse the repository at this point in the history

  2. Clean up 

    Signed-off-by: Keran Yang <[email protected]>
    @KeranYang
    KeranYang committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    9aec159 View commit details
    Browse the repository at this point in the history

  3. Use noop watchers for redis - pending manual test 

    Signed-off-by: Keran Yang <[email protected]>
    @KeranYang
    KeranYang committed Oct 24, 2022
    Configuration menu
    Copy the full SHA
    bb990b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2022

  1. Clean up 

    Signed-off-by: Keran Yang <[email protected]>
    @KeranYang
    KeranYang committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    5954ba0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into generic-watermark-fetching

    @KeranYang
    KeranYang authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    8c7a3fc View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into generic-watermark-fetching

    @KeranYang
    KeranYang authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    cfdd0c7 View commit details
    Browse the repository at this point in the history

  4. Address comments 

    Signed-off-by: Keran Yang <[email protected]>
    @KeranYang
    KeranYang committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    b9be650 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'numaproj:main' into generic-watermark-fetching

    @KeranYang
    KeranYang authored Oct 25, 2022
    Configuration menu
    Copy the full SHA
    5ab10e3 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'generic-watermark-fetching' of github.com:KeranYang/num… 

    …aflow into generic-watermark-fetching
    @KeranYang
    KeranYang committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    a7f5ce4 View commit details
    Browse the repository at this point in the history

  7. Address comments 

    Signed-off-by: Keran Yang <[email protected]>
    @KeranYang
    KeranYang committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    2295b3f View commit details
    Browse the repository at this point in the history

  8. Address comments 

    Signed-off-by: Keran Yang <[email protected]>
    @KeranYang
    KeranYang committed Oct 25, 2022
    Configuration menu
    Copy the full SHA
    6842b53 View commit details
    Browse the repository at this point in the history