-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: idle watermark v0 #520
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Why not use the value at the head? |
vigith
reviewed
Feb 2, 2023
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
This reverts commit 1cfb7ad. Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
Signed-off-by: jyu6 <[email protected]>
jy4096
commented
Feb 3, 2023
vigith
approved these changes
Feb 3, 2023
whynowy
reviewed
Feb 4, 2023
Signed-off-by: jyu6 <[email protected]>
ashwinidulams
pushed a commit
that referenced
this pull request
Feb 14, 2023
Signed-off-by: jyu6 <[email protected]> Co-authored-by: jyu6 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480
Local Test
example pipeline
Current main branch result
sliding 0 log
sliding 1 log
etc.
PR result
sliding 0 log
[SOLVED] Need discussion @vigith @whynowy @ashwinidulams
Currently we use the tail offsetWatermark to replace idle watermark, so we can see a delay in data processing.
For example, in the above test case,
get watermark for offset 23
should have been1675310000000
(because the other processors always have idle watermark); however, because of the idle watermarks, the actual value is1675309900000
.