chore: watermark and eventtime in windowing operations #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ashwinidulams <[email protected]>
vigith
approved these changes
Mar 9, 2023
|
sure will do. |
whynowy
approved these changes
Mar 9, 2023
Signed-off-by: ashwinidulams <[email protected]>
vigith
approved these changes
Mar 15, 2023
Signed-off-by: Vigith Maurice <[email protected]>
auto-merge was automatically disabled
March 15, 2023 10:37
Pull request was converted to draft
whynowy
pushed a commit
that referenced
this pull request
Apr 3, 2023
Signed-off-by: ashwinidulams <[email protected]> Signed-off-by: Vigith Maurice <[email protected]> Co-authored-by: Vigith Maurice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for window operations today, we use window start time for both eventtime and watermark. with this PR, that will be changed to (window.endtime - millisecond)