Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: IdleWatermark unit test #640

Merged
merged 8 commits into from
Mar 28, 2023
Merged

fix: IdleWatermark unit test #640

merged 8 commits into from
Mar 28, 2023

Conversation

jy4096
Copy link
Contributor

@jy4096 jy4096 commented Mar 27, 2023 •
edited
Loading

update unit test

@jy4096
Copy link
Contributor Author

jy4096 commented Mar 27, 2023 •
edited
Loading

Test done.

@jy4096 jy4096 closed this Mar 27, 2023
@jy4096 jy4096 reopened this Mar 27, 2023
@jy4096 jy4096 marked this pull request as ready for review March 28, 2023 01:13
@vigith vigith changed the title fix: unit test fix: unit IdleWatermark test Mar 28, 2023
@vigith vigith changed the title fix: unit IdleWatermark test fix: IdleWatermark unit test Mar 28, 2023
@vigith vigith merged commit 0c79113 into main Mar 28, 2023
@vigith vigith deleted the fix-unit-test-230327 branch March 28, 2023 01:14
jy4096 added a commit that referenced this pull request Mar 28, 2023
@jy4096
Revert "fix: IdleWatermark unit test (#640)"
e6b45db 
This reverts commit 0c79113.
whynowy pushed a commit that referenced this pull request Apr 3, 2023
@jy4096 @whynowy
fix: IdleWatermark unit test (#640)
a0dce69 
Signed-off-by: jyu6 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vigith vigith vigith approved these changes

@whynowy whynowy Awaiting requested review from whynowy whynowy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jy4096 @vigith