feat: Merge UX server code #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 22, 2022 12:13
Signed-off-by: Krithika Vijayakumar <[email protected]>
Signed-off-by: Krithika Vijayakumar <[email protected]>
Krithika3
commented
Jun 22, 2022
|
|
||
| func TestRoutes(t *testing.T) { | ||
| // skipping this test for the time being | ||
| t.Skip() |
There was a problem hiding this comment.
Had to skip this test as it was panicking with the below error:
panic: failed to get kubeconfig, unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined [recovered]
panic: failed to get kubeconfig, unable to load in-cluster configuration, KUBERNETES_SERVICE_HOST and KUBERNETES_SERVICE_PORT must be defined```
There was a problem hiding this comment.
I believe it is because of the image used to run the test
whynowy
approved these changes
Jun 22, 2022
|
|
||
| func TestRoutes(t *testing.T) { | ||
| // skipping this test for the time being | ||
| t.Skip() |
| @@ -0,0 +1,59 @@ | |||
| package main | |||
There was a problem hiding this comment.
Merge this into the main binary commands in the following up PRs.
whynowy
changed the title
whynowy
pushed a commit
that referenced
this pull request
Jul 8, 2022
* Moved the api server folder to numaflow Signed-off-by: Krithika Vijayakumar <[email protected]> * Skipping routes test Signed-off-by: Krithika Vijayakumar <[email protected]> Co-authored-by: Krithika Vijayakumar <[email protected]> Signed-off-by: Derek Wang <[email protected]>
yhl25
pushed a commit
to yhl25/numaflow
that referenced
this pull request
Sep 1, 2022
* Moved the api server folder to numaflow Signed-off-by: Krithika Vijayakumar <[email protected]> * Skipping routes test Signed-off-by: Krithika Vijayakumar <[email protected]> Co-authored-by: Krithika Vijayakumar <[email protected]> Signed-off-by: Yashash H L <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Krithika Vijayakumar [email protected]
Explain what this PR does.
Fixes #TODO
or
Closes #TODO