Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines with Cycles: e2e testing, and pipeline validation #920

Merged
merged 31 commits into from
Aug 8, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
de2ebea
allow for cycles and add e2e test for it
juliev0 Aug 2, 2023
40109ea
validation logic for cycle
juliev0 Aug 3, 2023
95ded79
pipeline validation
juliev0 Aug 3, 2023
7f1c67d
cycle validation
juliev0 Aug 4, 2023
d3a374d
validation logic for join vertex
juliev0 Aug 4, 2023
358cb03
cycle validation
juliev0 Aug 4, 2023
922cbe1
cycles
juliev0 Aug 5, 2023
8d2dbba
name change
juliev0 Aug 5, 2023
acea0ed
e2e tests for pipelines with cycles
juliev0 Aug 5, 2023
b5b26b5
remove old comment
juliev0 Aug 5, 2023
81ebfe8
cycles test
juliev0 Aug 5, 2023
ddc6a2a
fix lint issue
juliev0 Aug 5, 2023
2c1c6c5
Merge remote-tracking branch 'upstream/main' into cycle
juliev0 Aug 5, 2023
e754a25
fix: empty commit
juliev0 Aug 7, 2023
8cea03d
fix: empty commit
juliev0 Aug 7, 2023
7a81e41
fix: empty commit
juliev0 Aug 7, 2023
5c78efb
fix: empty commit
juliev0 Aug 7, 2023
da8761e
fix: empty commit
juliev0 Aug 7, 2023
9fc6aaf
fix: empty commit
juliev0 Aug 7, 2023
1821a3a
try increasing timeout value in test
juliev0 Aug 7, 2023
ece5819
cycles
juliev0 Aug 7, 2023
2b8baf7
debugging
juliev0 Aug 7, 2023
c2a9caf
try adding sleeps for test
juliev0 Aug 7, 2023
f633a7d
fix: empty commit
juliev0 Aug 7, 2023
0b27178
remove temporary code
juliev0 Aug 7, 2023
46fe0e4
Merge remote-tracking branch 'upstream/main' into cycle
juliev0 Aug 7, 2023
9e9c9a8
remove temporary timeout values that were used during debugging
juliev0 Aug 7, 2023
ed7c939
correct way to not allow autoscaling
juliev0 Aug 8, 2023
6620187
examples of cycles
juliev0 Aug 8, 2023
92d0fb3
renamed example numbering
juliev0 Aug 8, 2023
9ad392b
fix: empty commit
juliev0 Aug 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions examples/10-cycle-to-self.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
apiVersion: numaflow.numaproj.io/v1alpha1
kind: Pipeline
metadata:
name: cycle-to-self
spec:
vertices:
- name: in
source:
http: {}
- name: retry
scale:
min: 1
disabled: true # don't scale this beyond one Pod since it doesn't make sense for this particular container, which uses in-memory storage
udf:
container:
# This will try each message up to 3 times before continuing, see https://github.com/numaproj/numaflow-go/tree/main/pkg/function/examples/retry
# (a more realistic example might retry only on failure)
image: quay.io/numaio/numaflow-go/map-retry:latest
- name: out
scale:
min: 1
sink:
log: {}
edges:
- from: in
to: retry
- from: retry
to: retry
conditions:
tags:
values:
- retry
- from: retry
to: out
conditions:
tags:
operator: not
values:
- retry
45 changes: 45 additions & 0 deletions examples/11-cycle-to-prev.yaml
juliev0 marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1,45 @@
apiVersion: numaflow.numaproj.io/v1alpha1
kind: Pipeline
metadata:
name: cycle-backward
spec:
vertices:
- name: in
source:
http: {}
- name: cat
udf:
builtin:
name: cat
- name: retry
scale:
min: 1
disabled: true # don't scale this beyond one Pod since it doesn't make sense for this particular container, which uses in-memory storage
udf:
container:
# This will try each message up to 3 times before continuing, see https://github.com/numaproj/numaflow-go/tree/main/pkg/function/examples/retry
# (a more realistic example might retry only on failure)
image: quay.io/numaio/numaflow-go/map-retry:latest
- name: out
scale:
min: 1
sink:
log: {}
edges:
- from: in
to: cat
- from: cat
to: retry
- from: retry
to: cat
conditions:
tags:
values:
- retry
- from: retry
to: out
conditions:
tags:
operator: not
values:
- retry
Loading