Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature receive postcapture notification #310

Merged
merged 30 commits into from
Dec 10, 2020
Merged

Feature receive postcapture notification #310

merged 30 commits into from
Dec 10, 2020

Conversation

seanwu1105
Copy link
Contributor

@seanwu1105 seanwu1105 commented Dec 8, 2020 •
edited
Loading

@seanwu1105
Remove unused rx-operators.
6ddbf45
@seanwu1105
Implement DiaBackendContactRepository.
8c56b06
@seanwu1105
Show contacts on contact-selection-dialog.
8ae3a38
@seanwu1105
Show progress spinner when fetching contacts with empty cache.
11e908f
@seanwu1105
Add argument for comparator to Table.insert method.
a021f40
@seanwu1105
Implement OnConflictStrategy.REPLACE for Table.insert.
34c1f4e
@seanwu1105
Implement comparator for Table.delete method.
afff62b
@seanwu1105
Update DiaBackendContact endpoint APIs.
d79fb9b
@seanwu1105
Merge branch 'develop' into feature-contacts
bdfdc2d
@seanwu1105
Refactor PushNotificationService.
deb9a13
@seanwu1105
Remove unused InviteContactResponse interface.
b14b608
@seanwu1105
Replace test account with mock account.
a08e314
@seanwu1105
Show notification when receving PostCapture.
02054ff
@seanwu1105
WIP: Implement polling to get expired assets.
eabdfb9
@seanwu1105
Merge branch 'feature-contacts' into feature-receive-postcapture-noti…
ee13759 
…fication
@seanwu1105
WORKAROUND: Implement polling to get expired assets.
804f8e5
@seanwu1105
Show notification on a PostCapture expired.
008d71e
@seanwu1105
Show only empty badge on inbox icon.
218b1ec
@seanwu1105
Merge branch 'develop' into feature-receive-postcapture-notification
cf5fa69
@seanwu1105 seanwu1105 added the enhancement New feature or request label Dec 8, 2020
@seanwu1105 seanwu1105 added this to the beta7.3 milestone Dec 8, 2020
@seanwu1105 seanwu1105 self-assigned this Dec 8, 2020
shc261392
shc261392 requested changes Dec 9, 2020
View reviewed changes
src/app/pages/home/home.page.ts Outdated Show resolved Hide resolved
@seanwu1105
Copy link
Contributor Author

@shc261392 I merge refactor-transaction branch and thus remove all polling workarounds in the app. The refactor implements the repository pattern for transactions from DIA backend. The repository will be updated (fetch the latest transaction list from the backend) when:

  1. calling getAll$() method
  2. push notification receive new transaction data

Hence, the local cache in the repository will always be update to date with the latest data from the backend.

Also, the repository will cache the transactions, and thus the loading time of getAll$() will be significantly faster after the first fetching. Finally, the transactions and their details pages have also been updated according to this refactor.

@seanwu1105 seanwu1105 merged commit f493cdb into develop Dec 10, 2020
@seanwu1105 seanwu1105 deleted the feature-receive-postcapture-notification branch December 10, 2020 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shc261392 shc261392 shc261392 approved these changes

Assignees

@seanwu1105 seanwu1105

Labels
enhancement New feature or request
Projects
None yet
Milestone
beta 7.3
Development

Successfully merging this pull request may close these issues.
2 participants
@seanwu1105 @shc261392