Implement memory cache for PostCaptures. #600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shc261392
approved these changes
Mar 30, 2021
src/app/shared/services/dia-backend/asset/dia-backend-asset-repository.service.ts
Outdated
Show resolved
Hide resolved
shc261392
approved these changes
Mar 30, 2021
This was referenced Oct 1, 2021
This was referenced Nov 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #554.
According to the discussion on mid-sprint kickoff, implement in-memory cache for PostCaptures to provide better UX.
asset_filein memory.asset_filequantity.This is NOT an ideal cache implementation as we should build a safer and more structural LRU cache by leveraging declarative caching tool kits, such as
ngsw. However, we do not have enought time for now.Tested on Brave browser and Exodus 1.