New schema pictures / support mobile view #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lebaudantoine
approved these changes
Mar 19, 2024
the desktop image is split in half for mobiles and set up with slides
the desktop image is split in half for mobiles and set up with slides. We also add some screen reader only text to describe the images in a semantic way.
- use a paragraph instead of a div so that screen reader support is better (keyboard shortcuts better support paragraphs) - use a non-breaking space before the exclamation mark to prevent a lonely "!" when space is laking - add a screen-reader specific heading so that screen reader users dont mistakenly think this button is tied to the h3 just above
new asset from Johann
manuhabitela
force-pushed
the
feat/schemas
branch
from
442f8d4
to
5d0bfb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Show communs schema pictures correctly on mobile and update all pictures to new ones from Johann