Fix flaky tests that use std::env::set_var
#253
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix flaky tests that use
std::env::set_var
.std::env::set_var
is not safe to be used in parallel.Add
#[ignore]
statements to these tests.Add an extra test step to
ci.sh
, as I don't think there is a better way mark certain tests as single threaded only.Reproducer:
Will fail very fast.
Doesn't fail:
Reference: rust-lang/rust#27970