Only un-escape unicode character encoding color codes Fix #1124 #1147
Conversation
|
I was not able to run the tests on my computer, but they seems to work in github action. |
|
@Socolin This is still open, build issues, merge conflicts. Any chance of having a look? |
|
I'll take a look I did not saw the build error I was waiting for some feedback on this. |
|
Your unit test is failing. See Details, nearly near the bottom. |
|
Hello, the test result is not available anymore could you trigger the pipeline again so I can see the errors ? I will have time again to look at this in the coming weeks. |
|
I did a manual merge from main (who had changed) on the web here, and got in some compiler errors. I think it is faster if you just fix those than for me to clone your repo. Then the build should work again. It seems to only be some small glitches, braces etc |
|
Sorry for the delay, I finally got the time to take a look, I rebased the branch + force push and did the fix, all should be good now :) |
|
Lgtm, any comments @manfred-brands , @stevenaw ? |
There was a problem hiding this comment.
This looks great thanks for your contribution @Socolin
No concerns from what I can research about this, but I admit that console colors are not something I know much about. I'd appreciate another pair of eyes from a team member. Would it make sense to add a few more negative tests for cases with leading [ but otherwise invalid formats after?
| [TestCase("\\u001", "\\u001")] | ||
| [TestCase("\\u01", "\\u01")] | ||
| [TestCase("\\u1", "\\u1")] | ||
| [TestCase("\\u001b6", "\u001b6")] | ||
| [TestCase("\\u001b6", "\\u001b6")] | ||
| [TestCase("\\u001b[0m", "\u001b[0m")] |
There was a problem hiding this comment.
request: Would it make sense to add a test for a few more invalid inputs, such as a leading [ but missing trailing m ?
Fixes #1124