Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add System.Runtime.InteropServices.RuntimeInformation dependency for netcoreapp1.0 #418

Merged
merged 1 commit into from
Nov 19, 2017

Conversation

halex2005
Copy link
Contributor

Possible fix for #365.

Running dotnet test for C# and VB.NET projects targeting netcoreapp-1.0 always failed with the error:

An exception occurred while invoking executor 'executor://nunit3testexecutor/': Could not load file or assembly 'System.Runtime.InteropServices.RuntimeInformation, Version=4.0.1.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'. The system cannot find the file specified.

Here is one of failed build for example: https://travis-ci.org/halex2005/dotnet-new-nunit/jobs/304079301

@rprouse
Copy link
Member

rprouse commented Nov 19, 2017

Looks good to me.

bitmoji

@rprouse rprouse merged commit 8fa69db into nunit:master Nov 19, 2017
@halex2005 halex2005 deleted the patch-1 branch November 20, 2017 17:49
@halex2005
Copy link
Contributor Author

@rprouse, can we release this merged PR to nuget? I'd like to test it on travis

@OsirisTerje
Copy link
Member

@halex2005 You can get a package from the dev feed, look at https://www.myget.org/feed/nunit/package/nuget/NUnit3TestAdapter/3.9.0-dev-00581 I am sorry it has the wrong version number, I'll fix that, but for now this is the package with your fix.

@halex2005
Copy link
Contributor Author

@OsirisTerje, thanks, I'll try it

@halex2005
Copy link
Contributor Author

@rprouse, @OsirisTerje
Fix works, I have first green build in travis with it https://travis-ci.org/halex2005/dotnet-new-nunit/jobs/305406083
I'll wait for nuget release for now

@halex2005
Copy link
Contributor Author

@OsirisTerje, @rprouse, when the next release of NUnit VS Test Adapter is planned?

@rprouse
Copy link
Member

rprouse commented Dec 13, 2017

@halex2005 not sure. There are some issues in 15.5 that we are tracking down. We likely want to get them fixed as soon as possible, so may delay for that. @OsirisTerje is this issue serious enough for a point release?

@OsirisTerje
Copy link
Member

I've moved the 3.10 milestone to early January. I think that is most realistic, if not something pops up now with the 15.5 issues that require us to push out a point release. There are also a few more issues I would have liked to fix for 3.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants