Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated for supporting VS 2019 #590 #591

Merged
merged 4 commits into from
Jan 26, 2019
Merged

Updated for supporting VS 2019 #590 #591

merged 4 commits into from
Jan 26, 2019

Conversation

OsirisTerje
Copy link
Member

No description provided.

rprouse
rprouse approved these changes Jan 25, 2019
View reviewed changes
Copy link
Member

@rprouse rprouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comments 😄

src/NUnit3TestAdapterInstall/source.extension.vsixmanifest Outdated Show resolved Hide resolved
src/NUnit3TestAdapterInstall/source.extension.vsixmanifest Show resolved Hide resolved
@rprouse rprouse mentioned this pull request Jan 25, 2019
Closed
@rprouse
Copy link
Member

rprouse commented Jan 25, 2019

I changed the Azure DevOps build pipeline to use dotnet restore instead of NuGet.exe restore plus pushed a minor change to the installer project file. Still waiting for AppVeyor, but Azure DevOps build is now succeeding.

@rprouse rprouse merged commit 0149ee3 into master Jan 26, 2019
@rprouse rprouse deleted the VS2019 branch January 26, 2019 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rprouse rprouse rprouse approved these changes

@jnm2 jnm2 Awaiting requested review from jnm2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OsirisTerje @rprouse