New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert.Multiple produces new tests in the report if inner assertions fail #631

Merged

OsirisTerje merged 1 commit into nunit:master from nvborisenko:issue-630

Jul 10, 2019

Contributor

nvborisenko commented Jul 2, 2019

This PR fixes #630 (Assert.Multiple produces new tests in the report if inner assertions fail).

Changes:

Reworked parsingtest-case xml node to not consider assertions node
Don't set ErrorMessage property for passed tests


          Don't consider assertions xml node in report

7b022f9

OsirisTerje approved these changes

View reviewed changes

src/NUnitTestAdapter/TestConverter.cs

-                          if (testcaseResult!=null && testcaseResult.Outcome == TestOutcome.Failed && results.Any() && results.All(o => o.Outcome != TestOutcome.Failed))
-                              results.First().Outcome = TestOutcome.Failed;
+                              results.Add(testcaseResult);

Member

OsirisTerje Jul 9, 2019

Here you might add null. What is the effect of that?

OsirisTerje merged commit 9cc7cef into nunit:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet