Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LICENSE.txt via license element #643

Merged
merged 1 commit into from
Aug 10, 2019

Conversation

mikkelbu
Copy link
Member

@mikkelbu mikkelbu commented Aug 9, 2019

Fixes #580

@OsirisTerje
Copy link
Member

@mikkelbu Fungerer build -t package ?

@OsirisTerje OsirisTerje merged commit b56e073 into nunit:master Aug 10, 2019
@mikkelbu
Copy link
Member Author

@mikkelbu Fungerer build -t package ?

Så vidt jeg har kunnet teste lokalt, så virker package target, og LICENSE.txt er nævnt i metadata. Det ligner også, at det har fungeret på appveyor, https://ci.appveyor.com/project/CharliePoole/nunit3-vs-adapter/builds/26600339#L1809

@mikkelbu mikkelbu deleted the feat/use-license-element branch August 10, 2019 18:26
@OsirisTerje
Copy link
Member

OsirisTerje commented Aug 10, 2019

Yes, tried locally, it worked :-)

Another thing - wonder why the Azure Pipeline builds have stopped running ? That is, for the pull requests. They work on master

@mikkelbu
Copy link
Member Author

Another thing - wonder why the Azure Pipeline builds have stopped running ? That is, for the pull requests. They work on master

I created nunit/nunit#3338 one week ago and just spent 1 hour without any progress, but I'll examine it some more tonight.

In the NUnit project master was passing jul 28
https://nunit.visualstudio.com/NUnit/_build/results?buildId=1892
but when I triggered a rebuild it failed on aug 3
https://nunit.visualstudio.com/NUnit/_build/results?buildId=1905
and examine the logs it seems that the image has been updated (git-lfs was bumped from 2.7.2 to 2.8.0 and the full change log is here microsoft/azure-pipelines-image-generation@fcd0f07 - I guess).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix licenseUrl in nuspec, will be deprecated
2 participants