Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to set timeout #595

Merged
merged 6 commits into from
Mar 23, 2023
Merged

Add option to set timeout #595

merged 6 commits into from
Mar 23, 2023

Conversation

holymp2006
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
Fixed tickets #546

Add config option to set timeout.

@cmgmyr
Copy link
Collaborator

cmgmyr commented Sep 3, 2022

Hi @holymp2006, this looks like a great addition! Can you please remove your aabac89 commit and rebase from the current master branch? That change is no longer needed.

@holymp2006
Copy link
Contributor Author

Hello @cmgmyr , reverted the aabac89 commit and rebased from the current master branch.

@cmgmyr
Copy link
Collaborator

cmgmyr commented Sep 3, 2022

Thanks @holymp2006, it looks like we have some various failures from the test suite. Rebasing or pulling in master might fix them, or there might be other issues in the changed code. Please LMK if you need help going through any of the items.

@JustSteveKing JustSteveKing added the enhancement New feature or request label Sep 6, 2022
@gemal
Copy link

gemal commented Dec 1, 2022

what is needed for this pull to be merged?

@gemal
Copy link

gemal commented Mar 22, 2023

can this be merged?

@cmgmyr
Copy link
Collaborator

cmgmyr commented Mar 22, 2023

I rebased off current master, and most of the failures seem to be around styling. I'll take a closer look shortly and we should be able to merge

@gemal
Copy link

gemal commented Mar 22, 2023

image

@gemal
Copy link

gemal commented Mar 23, 2023

Nice! All checks have passed...

@cmgmyr cmgmyr merged commit a71a20b into nunomaduro:master Mar 23, 2023
@joelvh
Copy link

joelvh commented Oct 17, 2023

I'm experiencing timeouts for a while now and this is a great feature to help resolve that. When will this be released?

@cmgmyr
Copy link
Collaborator

cmgmyr commented Oct 20, 2023

Just released in v2.9.0 👍

@joelvh
Copy link

joelvh commented Oct 20, 2023

Thank you @cmgmyr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants