Add testing on version 2.5.0 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontaras
approved these changes
Apr 24, 2024
| @@ -4,7 +4,7 @@ set -e | |||
| cd "$(dirname "$0")" | |||
| ./check.sh | |||
|
|
|||
| : ${NUODB_CP_VERSION:="2.4.1"} | |||
| : ${NUODB_CP_VERSION:="2.5.0"} | |||
There was a problem hiding this comment.
Rather than having to update the supported version in three places (CircleCI and the two drivers), why not have it set as the default in the makefile?
There was a problem hiding this comment.
This change actually was not needed in order to enable testing of 2.5.0. I only made this change so that if someone invokes the script directly, they use the latest version. This change has no effect on the CircleCI runs whatsoever and is only for convenience.
This change adds CircleCI jobs for 2.5.0. The 2.4.1 jobs will be maintained as a "lowest supported version" test. The upgrade to 2.5.0 exposed an issue with state reporting where a project or database is prematurely reported as Available and then transitions to Modifying. This change adds a workaround as we wait for a fix in the Control Plane.
adriansuarez
force-pushed
the
asuarez/test-2.5.0
branch
from
f886724
to
bc9a8d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.