Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against latest dev version (main) using KWOK #55

Merged
merged 1 commit into from
May 28, 2024

Conversation

adriansuarez
Copy link
Collaborator

This change allows us to test against the latest development version of the DBaaS Control Plane using KWOK. This is useful because KWOK gives us the highest test coverage of all test drivers and allows us to test features as soon as they have been pushed to main on nuodb-control-plane, even if they have not been deployed to the test cluster used by the "External DBaaS" variant.

@adriansuarez
Copy link
Collaborator Author

adriansuarez commented May 24, 2024

The Minikube failure is due to a known issue that will be fixed in 2.6.0 (HelmApp updates not being retried on wrapped "409 Conflict").

I'm not sure what the "External DBaaS" failure is about, but it seems related to the Ingress controller (EOF). We are still using HAProxy, which is famously unreliable when ssl-passthrough is used. Hopefully switching to Nginx in the dev cluster fixes this.

This change allows us to test against the latest development version of
the DBaaS Control Plane using KWOK. This is useful because KWOK gives us
the highest test coverage of all test drivers and allows us to test
features as soon as they have been pushed to main on
nuodb-control-plane, even if they have not been deployed to the test
cluster used by the "External DBaaS" variant.

This change also restores some test coverage that was lost by only
running `terraform validate` on the example configs. If the REST server
is the latest dev version, then we can enable full testing of the
example configs, since all resources and data sources should be
supported.
Copy link
Collaborator

@sivanov-nuodb sivanov-nuodb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@adriansuarez adriansuarez merged commit 0157015 into main May 28, 2024
8 checks passed
@adriansuarez adriansuarez deleted the asuarez/kwok-latest branch May 28, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants