[T2A2][W15-A1] Xu Bili #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid the long boolean expression which much more difficult to read compared to if-else statements.
|
Ready for review |
mauris
reviewed
Feb 2, 2017
| @@ -266,7 +270,7 @@ private static void processProgramArgs(String[] args) { | |||
| setupGivenFileForStorage(args[0]); | |||
| } | |||
|
|
|||
| if(args.length == 0) { | |||
| if (args.length == 0) { | |||
There was a problem hiding this comment.
good that coding standard violation was spotted.
| @@ -339,8 +345,28 @@ private static boolean hasValidParentDirectory(Path filePath) { | |||
| * If a file already exists, it must be a regular file. | |||
| */ | |||
| private static boolean hasValidFileName(Path filePath) { | |||
| return filePath.getFileName().toString().lastIndexOf('.') > 0 | |||
| && (!Files.exists(filePath) || Files.isRegularFile(filePath)); | |||
| if (!hasExtension(filePath)) { | |||
There was a problem hiding this comment.
good that the long condition has been made easier to read.
| private static String removePrefixSign(String s, String sign) { | ||
| return s.replace(sign, ""); | ||
| private static String removePrefix(String fullString, String prefix) { | ||
| return fullString.replace(prefix, ""); |
There was a problem hiding this comment.
as mentioned in tutorial, the replace behaviour would also remove instances of the prefix argument that are found else where than the start of fullString
| @@ -1150,8 +1204,8 @@ private static String getUsageInfoForExitCommand() { | |||
| * @param sign Parameter sign to be removed | |||
| * @return string without the sign | |||
There was a problem hiding this comment.
need to update the header comments after updating the method.
|
Some comments added. Feel free to add more comment if you have any questions. Once you are done, you may close the PR after reading comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for [LO-Refactor] and [LO-MethodAbstraction].