Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[W4.6b][W13-A4]Yuan Quan #31

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

YuanQLLer
Copy link

Implement Java Enum class

eugenepeh and others added 2 commits January 30, 2018 11:32
The default storage file 'addressbook.txt' is not provided by default.
The program has to create a new storage file, and this process is 
written in the program's log.

Due to the additional information in the log, the first test run after 
cloning the master always result in failure, as the additional
information creates a difference between actual.txt and expected.txt,
causing the test to fail.

Let's add the default storage file 'addressbook.txt' into the test
folder so that the runtests.bat will stop failing on first run.
@nus-se-pr-bot
Copy link

Hi @YuanQLLer, your pull request title is invalid.

For phase A, it should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2).

For phase B, it should be in the format of [v1.x][Team ID] Product Name.

Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

1 similar comment
@nus-se-pr-bot
Copy link

Hi @YuanQLLer, your pull request title is invalid.

For phase A, it should be in the format of [Learning Outcome ID][Team ID] Your Name, where [Learning Outcome ID] has no dashes or spaces (e.g. [W3.1a]) and [Team ID] has one dash only and no spaces (e.g. [W14-A2] means Wednesday 2pm (14 hrs), Phase A, Team 2).

For phase B, it should be in the format of [v1.x][Team ID] Product Name.

Please follow the instructions given strictly and edit your title for reprocessing.

Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the master branch is pointing at so that each PR you submit only consist of commits meant for the activity.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

@YuanQLLer YuanQLLer changed the title [W4.6b][T1-A4]Yuan Quan [W4.6b][W13-A4]Yuan Quan Feb 9, 2018
@nus-se-pr-bot
Copy link

Hi @YuanQLLer,

Your Github username is not recognized. Please post here.

Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR.

@brandonyeoxg
Copy link

brandonyeoxg commented Feb 11, 2018

Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail.
Good effort made!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants