-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[W4.6b][W13-A4]Yuan Quan #31
base: master
Are you sure you want to change the base?
Conversation
The default storage file 'addressbook.txt' is not provided by default. The program has to create a new storage file, and this process is written in the program's log. Due to the additional information in the log, the first test run after cloning the master always result in failure, as the additional information creates a difference between actual.txt and expected.txt, causing the test to fail. Let's add the default storage file 'addressbook.txt' into the test folder so that the runtests.bat will stop failing on first run.
Hi @YuanQLLer, your pull request title is invalid. For phase A, it should be in the format of For phase B, it should be in the format of Please follow the instructions given strictly and edit your title for reprocessing. Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
1 similar comment
Hi @YuanQLLer, your pull request title is invalid. For phase A, it should be in the format of For phase B, it should be in the format of Please follow the instructions given strictly and edit your title for reprocessing. Submit only one learning outcome per pull request (unless otherwise stated in instructions) and do remember to create your branches from the commit where the Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
Hi @YuanQLLer, Your Github username is not recognized. Please post here. Note: this comment is posted by a bot. If you believe this is done in error, please create an issue at cs2103-pr-bot and add a link to this PR. |
Accepting this PR without a review because another of your PRs for this tutorial was reviewed in detail. |
Implement Java Enum class