Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnu_legacy: with GNU, write foreground first, else background first. #54

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

sylvestre
Copy link

@sylvestre
Copy link
Author

I will update lscolors and rust-coreutils after that

@fdncred
Copy link

fdncred commented Dec 14, 2023

I've been following the discussion on lscolors. This seems reasonable to me.

@sylvestre
Copy link
Author

@fdncred thanks. Would it be possible to merge this PR and do a new release of this crate? thanks

@fdncred
Copy link

fdncred commented Dec 18, 2023

I'm fine with it. @sholderbach what do you think? do you have time to publish a release here?

@sholderbach
Copy link
Member

Looks good!

I can take care of shipping the release later.

For Nushell/Reedline we would wait on the next lscolors release if we go for a minor version. Alternatively we could ship this as a patch release (API and overall design is constant, but the change in behavior could break tests for folks)

I would favor going with 0.50.0 for the release.

@sholderbach sholderbach merged commit 6c7e262 into nushell:main Dec 18, 2023
2 checks passed
@sylvestre sylvestre deleted the order branch December 25, 2023 11:12
@sylvestre
Copy link
Author

@sholderbach thanks!

@sylvestre
Copy link
Author

@sholderbach sorry for the pressure but do you have an eta for the new release? thanks

@fdncred
Copy link

fdncred commented Jan 22, 2024

@sylvestre I'm trying to find someone else on the nushell team to do a release. Sorry it's taking so long.

@fdncred
Copy link

fdncred commented Jan 22, 2024

@sylvestre FYI - Kubouch was able to do a release for us. nu-ansi-term 0.50 is in crates.io now. We're kind of stuck now in nushell because we're waiting on a lscolors release to update to the latest nu-ansi-term, lol.

@sylvestre
Copy link
Author

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants