Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Resizing window overwrites previous output #42

Open
sholderbach opened this issue Apr 10, 2021 · 4 comments
Open

[BUG] Resizing window overwrites previous output #42

sholderbach opened this issue Apr 10, 2021 · 4 comments
Labels
A-Display Area: Correctness of the display output and additional features needed there A-Events Area: Handling of incoming events (e.g. desired keypress not registered) bug Something isn't working P-medium Medium Priority: Bug affects quality of life, feature would improve experience for all

Comments

@sholderbach
Copy link
Member

Resizing the window now leads to unexpected behavior (observed if screen filled to the bottom, as well as if it is partially filled)

before resize (80x24)

image

after resize (80x30)

image
sholderbach added a commit to sholderbach/reedline that referenced this issue Apr 11, 2021
@sholderbach
Partial fix of resize repaint
ef1aa65 
Only fixes effect of overpainting after vertical resize (Issue nushell#42).
Horizontal resizes wrap the text with the cursor into overpaint situations.

+ remove superfluous `enable_raw_mode`
@sholderbach
Copy link
Member Author

sholderbach commented Apr 11, 2021 •
edited
Loading

First naive approach at resetting the cursor location seems to only work for vertical resizing when performed slowly. Large resizing (both manually and by maximizing) still breaks.

Edit: corrected direction to vertical

@sophiajt
Copy link
Contributor

I just added support for some resize support for the current prompt+input. While we don't have control over what's already on the screen, we can at least cleanup the current input the user is working on.

@sholderbach
Copy link
Member Author

Horizontal resizing (left/right) now seems to mostly work. Vertical resizing (up/down) still eats lines. Will try to take a deeper look

@sholderbach sholderbach added the bug Something isn't working label Nov 7, 2021
@sholderbach sholderbach added A-Display Area: Correctness of the display output and additional features needed there A-Events Area: Handling of incoming events (e.g. desired keypress not registered) P-high High Priority: Annoying bug, should be addressed with the next release labels Nov 28, 2021
@sholderbach sholderbach mentioned this issue Nov 28, 2021
Closed
@sholderbach
Copy link
Member Author

Status after #217:
Vertical resizing doesn't seem to eat lines as readily now. Changing the vertical size with the prompt at the bottom still causes #157
Horizontal resizing is now liberally eating previous output

@sholderbach sholderbach added P-medium Medium Priority: Bug affects quality of life, feature would improve experience for all and removed P-high High Priority: Annoying bug, should be addressed with the next release labels Feb 3, 2022
@sholderbach sholderbach mentioned this issue Mar 25, 2022
Closed
@sholderbach sholderbach mentioned this issue Apr 29, 2023
Closed
@Banyc Banyc mentioned this issue Apr 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Display Area: Correctness of the display output and additional features needed there A-Events Area: Handling of incoming events (e.g. desired keypress not registered) bug Something isn't working P-medium Medium Priority: Bug affects quality of life, feature would improve experience for all
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sophiajt @sholderbach